Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create local data directories if necessary #370

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

shoyer
Copy link
Contributor

@shoyer shoyer commented Aug 15, 2023

Creating a local data directory with Pooch checks that the local directory is writeable. This is important if downloading data, but if the files already exist is unnecessary.

This came up because we would like to store data for Pooch in readable but non-writable directories. In particular, the directories in which our build system installs Python are not writable.

Creating a local data directory with Pooch checks that the local
directory is writeable. This is important if downloading data, but if
the files already exist is unnecessary.

This came up because we would like to store data for Pooch in readable
but non-writable directories. In particular, the directories in which
our build system installs Python are not writable.
@santisoler
Copy link
Member

Thanks @shoyer for opening this PR. It looks good to me! I would wait for @leouieda's review to merge it.

@leouieda leouieda changed the title Only create local data directories if necessary. Only create local data directories if necessary Oct 3, 2023
@leouieda leouieda merged commit 8aa2fc3 into fatiando:main Oct 3, 2023
27 checks passed
@welcome
Copy link

welcome bot commented Oct 3, 2023

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda
Copy link
Member

leouieda commented Oct 3, 2023

Thanks @shoyer and @santisoler!

@shoyer shoyer deleted the no-local-write branch October 3, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants