-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: add support for old and new Zenodo APIs #375
Merged
Merged
Commits on Oct 17, 2023
-
Fix bug: update Zenodo downloader for new API
Update the Zenodo downloader to work with the new Zenodo API. Use the `filename` key for getting the filenames of all files in a repository. Update the generated download url based on heuristics: the link present in the API reference doesn't work at the moment). Update the method that populates the registry: use the new `filename` key and specify that the checksums are now md5.
Configuration menu - View commit details
-
Copy full SHA for ddfc2b2 - Browse repository at this point
Copy the full SHA ddfc2b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6be96a - Browse repository at this point
Copy the full SHA c6be96aView commit details -
Configuration menu - View commit details
-
Copy full SHA for de956d5 - Browse repository at this point
Copy the full SHA de956d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23e2057 - Browse repository at this point
Copy the full SHA 23e2057View commit details
Commits on Oct 20, 2023
-
Support both the legacy and the new Zenodo API
Detect which API are we interacting with and generate the download url and/or populate the registry accordingly.
Configuration menu - View commit details
-
Copy full SHA for 6db2a99 - Browse repository at this point
Copy the full SHA 6db2a99View commit details -
Use pytest-httpserver to test support for old and new APIs
Test if `ZenodoRepository` correctly supports both the old and new Zenodo APIs. Use `pytest-httpserver` to run a local server that returns API response that mimics the Zenodo ones. Define a `base_api_url` class attribute for `ZenodoRepository` so we can override it in tests.
Configuration menu - View commit details
-
Copy full SHA for c5159ad - Browse repository at this point
Copy the full SHA c5159adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3634bb3 - Browse repository at this point
Copy the full SHA 3634bb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5bfc84 - Browse repository at this point
Copy the full SHA d5bfc84View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.