Use a variable to set the default request timeout #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a variable in `pooch.downloaders` allows users to potentially increase it if they require and allows us to update it easily if required as well.
|
@paddyroddy had a few minutes to spare so I made this. 30s should be more than enough since it only timeouts if there is no response at all in this time frame. But if it's a variable and you really need it you can set it to a larger value. Will merge as soon as tests pass and then cut a bugfix release (probably tomorrow or Friday). |
|
Thanks! I had done a similar variable, but was trying to work out a way of not hard coding it |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a variable in
pooch.downloadersallows users to potentially increase it if they require and allows us to update it easily if required as well. Set it to 30s instead of 5s to allow for slow connections.Relevant issues/PRs:
Fixes #409