Skip to content

Commit

Permalink
update todos
Browse files Browse the repository at this point in the history
  • Loading branch information
flo-schu committed Jul 13, 2023
1 parent 4fa11e6 commit a4ef9d1
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions CADETProcess/optimization/surrogate.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,16 +218,18 @@ def surrogate_obj_fun(x):

def find_minimum(self, var_index, plot_directory):
"""
TODO: Docstrings (GPT add docstrings, include warnings and errors,
use numpy style, imperative style)
DONE: 1. determine true minimum of optimization problem or use other
TODO: 2. implement finding of starting point
TODO: 3. find out why the optimizer does not converge on true solution
DONE: 3. find out why the optimizer does not converge on true solution
despite having a clear and simple problem.
- draw conditioned space and then compare surrogate with true
problem.
TODO: test surrogate model
FIXME: using a linear space for x-fix may violate constraints
FIXME: decoupling the optimizer from the valid parameter space has
DONE: using a linear space for x-fix may violate constraints
DONE: decoupling the optimizer from the valid parameter space has
conflicts with constraints. How to I skip parameter proposals
that are not feasible, because of the variable which should not
be optimized
Expand Down

0 comments on commit a4ef9d1

Please sign in to comment.