-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change unittest to pytest #192
Conversation
645b820
to
31a4127
Compare
For reference, this is how we do it in CADET-Python: https://github.com/cadet/CADET-Python/blob/master/.github/workflows/pipeline.yml |
fbc1c10
to
7ab2fed
Compare
73f3404
to
3e7f58b
Compare
994a3a7
to
da4976b
Compare
Removed coverage for a later issue #144. Pytest with coverage as i used needs way to long for a simple push (~50%). Considering using it just on merge or action. Pytest alone should work. |
This one here could also be marked as CADET-Process/tests/test_cadet_adapter.py Line 157 in ce627e2
|
da4976b
to
2809904
Compare
Done
and removed coverage from dependency. |
8ad652f
to
1aa2228
Compare
fc25df1
to
de162b9
Compare
Still many warnings, but more or less the same as in dev. Tests run overall slightly slower compared to unittest. Otherwise like in dev, now 220 tests were run, 3 skipped. |
Any new warnings or simply the same as with |
As far as i can tell simply the same as with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments / Changes.
Alrighty, looks good to me. Please rebase and clean up the git history, then we can merge. |
7b819d6
to
d66ba21
Compare
Done |
d66ba21
to
1d4f723
Compare
1d4f723
to
5ae6259
Compare
pytest.mark.slow
to ignore to complicated testsremoved - [ ] Using Coverage for coverage report to also cover #144