Merge pull request #10 from litencatt/configurable-timeout

Configurable Guzzle client timeout
faultline · Jul 31, 2018 · 68b5188 · 68b5188
2 parents 0253bb6 + d483058
commit 68b5188
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -16,6 +16,7 @@ $notifier = new Faultline\Notifier([
     'project' => 'faultline-php',
     'apiKey' => 'xxxxXXXXXxXxXXxxXXXXXXXxxxxXXXXXX',
     'endpoint' => 'https://xxxxxxxxx.execute-api.ap-northeast-1.amazonaws.com/v0',
+    'timeout' => '30.0',
     'notifications' => [
         [
             'type'=> 'slack',

diff --git a/src/Notifier.php b/src/Notifier.php
@@ -69,7 +69,7 @@ protected function postNotice($url, $notice)
                 'x-api-key' => $this->opt['apiKey']
             ],
             'json' => $notice,
-            'timeout'  => 5.0,
+            'timeout'  => (isset($this->opt['timeout']) ? $this->opt['timeout'] : 5.0),
         ];
         if (preg_match('/^5/', \GuzzleHttp\Client::VERSION)) {
             $config['exceptions'] = false;

diff --git a/tests/NotifierTest.php b/tests/NotifierTest.php
@@ -17,6 +17,7 @@ public function testNotify()
             'project' => 'faultline-test',
             'apiKey' => 'xxxxXXXXXxXxXXxxXXXXXXXxxxxXXXXXX',
             'endpoint' => 'https://xxxxxxxxx.execute-api.ap-northeast-1.amazonaws.com/v0',
+            'timeout' => '30.0',
             'notifications' => [
                 [
                     'type'=> 'slack',
@@ -49,6 +50,7 @@ public function testNotifyErrorShouldBeBoolean()
             'project' => 'faultline-test',
             'apiKey' => 'xxxxXXXXXxXxXXxxXXXXXXXxxxxXXXXXX',
             'endpoint' => 'https://example.com/v0',
+            'timeout' => '30.0',
             'notifications' => [
                 [
                     'type'=> 'slack',