Add ttl_days and history_days
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macmv
reviewed
Feb 21, 2024
| "FQL v10 schema update complete", | ||
| ]; | ||
| verifyLogs(log, logs); | ||
| await verifyCollections(client, config.collections); |
There was a problem hiding this comment.
does this actually check that ttl_days is set on the created collection?
There was a problem hiding this comment.
nice catch - should be fixed now
macmv
reviewed
Feb 21, 2024
macmv
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Collections are lacking support for
ttl_daysandhistory_days.Solution
Include these fields.
Result
Can manage collections with these fields via serverless config.
Out of Scope
n/a
Testing
Added tests.