-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace document/ref models with generic ref #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cynicaljoy
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some whitespace nits and whatever is causing the 6.0 check to fail
Fauna.Test/Serialization/Serializers/DynamicSerializer.Tests.cs
Outdated
Show resolved
Hide resolved
Fauna.Test/Serialization/Serializers/BaseRefSerializer.Tests.cs
Outdated
Show resolved
Hide resolved
pnwpedro
force-pushed
the
generic-refs
branch
3 times, most recently
from
October 9, 2024 15:05
149ccf5
to
8657855
Compare
SummarySummary
CoverageFauna - 80.7%
Delta Summary
|
cynicaljoy
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Below is the mapping for replaced types:
Motivation and context
BT-5145
The primary motivation is to support a case where a user defines a DataContext that includes documents with refs to other documents. In a LINQ query, they may wish to project the ref field, causing it to materialize as a sub-document, or may choose to just obtain the top level document leaving the ref field unmaterialized.
Given the LINQ API is strongly typed, there's no way to instruct a projection during a Select call unless you can obtain the type of the materialized ref (i.e. the document class).
A side effect is that this ultimately simplifies non-POCO cases.
How was the change tested?
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.