-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (almost) all missing XML docs #208
Conversation
f443201
to
373107f
Compare
373107f
to
202eab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this. Left some feedback, but nothing I'd consider critical or blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed a couple:
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from a small spacing typo (likely my fault). Thanks!
Co-authored-by: James Rodewig <[email protected]>
SummarySummary
CoverageFauna - 80.4%
Delta Summary
|
Description
Motivation and context
BT-5257
We missed a lot of this during development (unfortunately). This closes a big gap and isn't perfect, but we're in a much better state. Hopefully we'll be able to improve this as we go going forward.
How was the change tested?
Added documentation compilation to the build process so it tells us when we're missing docs now.
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.