Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fauna local no daemon text #528

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

Conversation

echo-bravo-yahoo
Copy link
Collaborator

Ticket(s): FE-6238

before:
image

after:
image

@echo-bravo-yahoo echo-bravo-yahoo changed the base branch from main to v3 December 13, 2024 23:01
@echo-bravo-yahoo echo-bravo-yahoo requested a review from a team as a code owner December 13, 2024 23:01
Copy link
Contributor

@cleve-fauna cleve-fauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, which might not be portable, how about we use the ping API:

https://docs.docker.com/reference/api/engine/version/v1.37/#tag/System/operation/SystemPing

dockerode exposes this via docker.ping() which is an async function

https://github.com/apocas/dockerode/tree/master?tab=readme-ov-file#docker

@echo-bravo-yahoo
Copy link
Collaborator Author

Instead of this, which might not be portable, how about we use the ping API:

https://docs.docker.com/reference/api/engine/version/v1.37/#tag/System/operation/SystemPing

dockerode exposes this via docker.ping() which is an async function

https://github.com/apocas/dockerode/tree/master?tab=readme-ov-file#docker

gotcha - sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants