Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerize fauna-client #537

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

containerize fauna-client #537

wants to merge 1 commit into from

Conversation

ptpaterson
Copy link
Contributor

@ptpaterson ptpaterson commented Dec 17, 2024

Ticket(s): FE-###

Problem

Some but not all exports from /lib/fauna-client.mjs are in the container as individual values, so we have several files that import some thing directly from "fauna-client", but other things by resolving the containerized values.

We include formatError as a containerized and mocked function, but it's not used.

Solution

containers the "fauna-client" module as a single item and mock the fields that are necessary.

Result

No functional changes.

Using functions from "fauna-client" module always come from the container.

I think this is more maintainable. It would have been more straightforward to add tests for formatQueryInfo if "fauna-client" was already treated as a containerized module.

Testing

Updated tests to work with new container value.

@ptpaterson ptpaterson requested a review from a team as a code owner December 17, 2024 14:03
Base automatically changed from tidy-query-info to v3 December 17, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant