Support v2 account API error shapes #554
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the future, v2 endpoints of the account API will have a different API shape than the current v1 shape.
v1:
v2:
(excuse the TS types, 🤣 )
Both API endpoints versions will need to be supported.
Solution
The existing
parseResponse
function already handles translating Account API errors to a catchable error in the CLI. By adding a new helper,parseErrorResponse
, we can normalize the error shape before building the error.Result
v1 and v2 error shapes are supported transparently for the consuming code.
Testing
Updated
parseResponse
tests to demonstrate normalizing and a few other small changes.