Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitor): revise support of Uptime Kuma #605

Merged
merged 3 commits into from
Oct 15, 2023
Merged

fix(monitor): revise support of Uptime Kuma #605

merged 3 commits into from
Oct 15, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented Oct 15, 2023

  1. Fix the typo "Ok".
  2. Document that the user should change the "Heartbeat Interval".
  3. Always use the message "OK" instead of trying to send more information.

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #605 (f75e5c5) into main (fb2e872) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          45       45           
  Lines        2300     2300           
=======================================
  Hits         2031     2031           
  Misses        259      259           
  Partials       10       10           
Flag Coverage Δ
unittests 88.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/monitor/updatekuma.go 95.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia added this to the 1.11.0 milestone Oct 15, 2023
@favonia favonia merged commit e65531a into main Oct 15, 2023
11 checks passed
@favonia favonia deleted the revise-kuma branch October 15, 2023 12:11
@favonia favonia mentioned this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant