Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitor): a more powerful hack for quirks of Uptime Kuma #774

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

favonia
Copy link
Owner

@favonia favonia commented Jun 27, 2024

Close #648.

@favonia
Copy link
Owner Author

favonia commented Jun 27, 2024

@JvdMaat I'm not sure what caused the strange bug you reported. However, the generation of notification messages has been completely rewritten (to support shoutrrr) so hopefully the problem is gone now? This PR additionally trim the failure messages before applying the existing ugly hack, in case messages with only space or newline characters were ever generated and somehow they confused the Uptime Kuma server.

@favonia favonia enabled auto-merge (squash) June 27, 2024 05:57
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (fd56d30) to head (ecd4fbc).

Files Patch % Lines
cmd/ddns/ddns.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          52       52           
  Lines        2155     2156    +1     
=======================================
+ Hits         1946     1947    +1     
  Misses        198      198           
  Partials       11       11           
Flag Coverage Δ
unittests 90.30% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia merged commit df565b9 into main Jun 27, 2024
12 of 13 checks passed
@favonia favonia deleted the uptimekuma-messages branch June 27, 2024 06:03
@favonia
Copy link
Owner Author

favonia commented Jun 27, 2024

@JvdMaat after reviewing the code I think the hack in this PR is overkill. I'm reverting it to a simpler/cleaner one that is hopefully sufficient. 🕵️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes Uptime Kuma gets the message "OK" when failing
1 participant