Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): specify interface name #941

Merged
merged 8 commits into from
Sep 24, 2024
Merged

feat(provider): specify interface name #941

merged 8 commits into from
Sep 24, 2024

Conversation

favonia
Copy link
Owner

@favonia favonia commented Sep 22, 2024

Close #713.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 96.12403% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.75%. Comparing base (640d30b) to head (ad85cd0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/protocol/local_iface.go 95.00% 2 Missing and 1 partial ⚠️
internal/provider/protocol/local_auto.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   95.81%   95.75%   -0.06%     
==========================================
  Files          60       62       +2     
  Lines        2722     2804      +82     
==========================================
+ Hits         2608     2685      +77     
- Misses        104      107       +3     
- Partials       10       12       +2     
Flag Coverage Δ
unittests 95.75% <96.12%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia force-pushed the specify-iface branch 8 times, most recently from afbf47d to 91742d0 Compare September 23, 2024 15:34
@favonia favonia marked this pull request as ready for review September 24, 2024 02:57
@favonia favonia merged commit 69f8cf2 into main Sep 24, 2024
10 checks passed
@favonia favonia deleted the specify-iface branch September 24, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get IP from a specific ethernet interface
1 participant