Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MessageReaction.UNDEFINED #370

Closed
wants to merge 1 commit into from
Closed

Added MessageReaction.UNDEFINED #370

wants to merge 1 commit into from

Conversation

Demindiro
Copy link

It is apparently possible to use emojis other than the six 'conventional'
emojis to react to messages. For now, this value serves as a placeholder.

Closes #368

It is apparently possible to use emojis other than the six 'conventional'
emojis to react to messages. For now, this value serves as a placeholder.
@madsmtm
Copy link
Member

madsmtm commented Dec 12, 2018

Thanks for the contribution 👍

What happens if you call reactToMessage with MessageReaction.UNDEFINED? This should be defined.

But you can wait with this until we've discussed the issue further in #368 😉

@Demindiro
Copy link
Author

I think it would make most sense to throw a ValueError, since it doesn't really make sense trying to send something that is undefined.

@madsmtm
Copy link
Member

madsmtm commented Dec 12, 2018

Yeah, but if someone's taking the value from Message.reactions and passing it into reactToMessage, then it won't work 😕

@madsmtm
Copy link
Member

madsmtm commented Jan 24, 2019

I merged #371 instead, and for now, passing invalid Message.reactions into reactToMessage will simply be ignored.

@madsmtm madsmtm closed this Jan 24, 2019
@chelsybradley15 chelsybradley15 linked an issue Mar 25, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants