add Contributors yaml file + Make first PR flow #43
Conversation
facebook-github-bot
added
the
CLA Signed
aboullaite
force-pushed
the
add-yaml-contributors
branch
2 times, most recently
from
534fb74 to
cc5c5a1
Compare
Signed-off-by: Mohammed Aboullaite <[email protected]> fix format issues Signed-off-by: Mohammed Aboullaite <[email protected]> fix format issues Signed-off-by: Mohammed Aboullaite <[email protected]> fix format issues Signed-off-by: Mohammed Aboullaite <[email protected]> fix format issues Signed-off-by: Mohammed Aboullaite <[email protected]> fix format issues Signed-off-by: Mohammed Aboullaite <[email protected]>
aboullaite
force-pushed
the
add-yaml-contributors
branch
from
5c811b4 to
967fe73
Compare
Signed-off-by: Mohammed Aboullaite <[email protected]>
There was a problem hiding this comment.
Please can you push your PR in the develop branch ? without the translation the code is not ready for production it will break the french experience !
We need to wait your other PR on french translation before merging this PR.
This issue #38 also have to be resolve before merging
|
I do not agree that we should block this PR because of french translation! The first language of the bot is english, and other translation are of course welcomed, but ad far as they don't block adding features! This PR will allow many first time contributors to make their first open source contribution, which is the number one goal of this project! Also, It's one of the important features that we should highlight for the promotion next Tuesday! |
This PR is related to #37! it adds the yaml file + a flow to let the bot guide users to make their contribution