Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Added hindi (hi) language support #68

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Added hindi (hi) language support #68

merged 2 commits into from
Jul 30, 2020

Conversation

ChiragTutlani
Copy link
Contributor

Is your pull request related to a problem? Please describe

This pull request adds hindi (hi) language support as per the issue #57

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.
  • I have added the label enhancement to my pull request.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2020
@ChiragTutlani ChiragTutlani marked this pull request as ready for review July 30, 2020 11:53
msgid ""
msgstr ""
"Project-Id-Version: PROJECT VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiragTutlani you can put your email here!

Copy link
Contributor

@elinguiuriel elinguiuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ChiragTutlani ! 👍

Please see my little remarks, and add hindi translation of GREETINGS and PERSISTENT_MENU in profile.py as described here

@@ -0,0 +1,613 @@
# Hindi translations for PROJECT.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All file in this project start with:

# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

Copy link
Contributor

@elinguiuriel elinguiuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks a lot!

@elinguiuriel elinguiuriel merged commit 3bab9fb into fbdevelopercircles:master Jul 30, 2020
@elinguiuriel
Copy link
Contributor

@ChiragTutlani make sur your Facebook language is hindi, and test your translation here : https://m.me/OpenSourceChatbot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants