-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redwood): add nau learning header customization #3
Conversation
c719213
to
aeaf417
Compare
* feat: add nau basic customization * fix: remove unnecessary courseOrg as argument
* fix: platform logo on mobile display * fix: hide course name on mobile
af4b574
to
6439ce5
Compare
6439ce5
to
a4df798
Compare
@dcoa can you fix the lint? |
Code looks ok but I still need to install quince and run some tests. Would you suggest TVM to have quince installed along side Nutmeg, our previous version? |
a4df798
to
e1f358a
Compare
e1f358a
to
a8789fe
Compare
TVM allows you to have different environments in the same machine without problem, it's a good option for local testing. |
Hi @sandroscosta have you been able to run the testing? Do you have any other issues that should be addressed? |
Hi @dcoa. Ran all the tests. Everything looks fine. The only thing I want to ask you is if you think we should cast our config variable as boolean, like const enabledOrgLogo = !!getConfig().ENABLED_ORG_LOGO || false; The rest of it is all ok. |
Hi @sandroscosta, thanks for your review. Answer your question it is been cast as a boolean in the capturing of the env variable, here
|
Fantastic. As I didn't see it in this PR, I never went and looked for it elsewhere. I'll just tweak the variable name, as I named it incorrectly in past tense. Would you mind if I do a commit into this branch? |
Rename the setting to be in the present tense, as a way to make it clearer. The setting is now called `ENABLE_ORG_LOGO`.
@dcoa I think that everything is valid on this PR. I'm going to merge this, if you agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR migrates the custom NAU header changes to the Redwood version.
How to test
tutor mounts add ./frontend-app-learning
.npm install
for both, the learning app and the header).module.config.js
file and add the following configuration.tutor images build learning-dev
.tutor dev start
.