fix: don't set dummy preedit when switching IM for LibreOffice (#172)

fcitx-contrib · Jul 13, 2024 · 5ffb9bf · 5ffb9bf
1 parent 48f1dbe
commit 5ffb9bf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.gitmodules b/.gitmodules
@@ -1,6 +1,6 @@
 [submodule "fcitx5"]
 	path = fcitx5
-	url = https://github.com/fcitx/fcitx5
+	url = https://github.com/fcitx-contrib/fcitx5
 [submodule "fcitx5-webview"]
 	path = fcitx5-webview
 	url = https://github.com/fcitx-contrib/fcitx5-webview

diff --git a/fcitx5 b/fcitx5
diff --git a/webpanel/webpanel.cpp b/webpanel/webpanel.cpp
@@ -360,7 +360,10 @@ void WebPanel::updateInputPanel(const Text &preedit, const Text &auxUp,
 
 void WebPanel::updateClient(InputContext *ic) {
     if (auto macosIC = dynamic_cast<MacosInputContext *>(ic)) {
-        macosIC->setDummyPreedit(bool(panelShow_));
+        // Don't set dummy preedit when switching IM. It will clear current cell
+        // in LibreOffice.
+        macosIC->setDummyPreedit(bool(panelShow_) &&
+                                 !macosIC->inputPanel().transient());
         if (!macosIC->isSyncEvent) {
             macosIC->commitAndSetPreeditAsync();
         }