Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split plugin to native and data; add table-extra #134

Merged
merged 2 commits into from
May 27, 2024
Merged

split plugin to native and data; add table-extra #134

merged 2 commits into from
May 27, 2024

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented May 27, 2024 •
edited
Loading

Test procedure is arbitrary:

  • Run npx serve on a local dir that contains meta-*.json and change pluginBaseAddress to http://localhost:3000/.
  • Change version and data_version in ~/Library/fcitx5/plugin/*.json to force outdated.
  • Update in About (need to reinstall current branch afterwards) and Plugin Manager.
  • Pure data update shouldn't trigger a process restart.

@eagleoflqj eagleoflqj requested a review from ksqsf May 27, 2024 02:36
ksqsf
ksqsf approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksqsf ksqsf merged commit 078cb64 into master May 27, 2024
@ksqsf ksqsf deleted the plugin branch May 27, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eagleoflqj @ksqsf