Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unix socket instead of tcp/ip #176

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Use unix socket instead of tcp/ip #176

merged 4 commits into from
Jul 11, 2024

Conversation

omegacoleman
Copy link
Contributor

@omegacoleman omegacoleman commented Jul 10, 2024 •
edited
Loading

  1. updated fcitx5-beast
  2. add build script to request static target from fcitx5-beast
  3. updated fcitx5-curl to do a better ini/arg parse and support both comms

@omegacoleman omegacoleman changed the title wip: use unix socket instead of tcp/ip Use unix socket instead of tcp/ip Jul 10, 2024
eagleoflqj
eagleoflqj approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed 2 bugs. Now it works for both UDS and TCP.
@ksqsf please also test a bit.

@eagleoflqj eagleoflqj requested a review from ksqsf July 11, 2024 03:10
ksqsf
ksqsf approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ksqsf ksqsf merged commit 48f1dbe into fcitx-contrib:master Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

@eagleoflqj eagleoflqj eagleoflqj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omegacoleman @ksqsf @eagleoflqj