Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterator is not pointer #1230

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: iterator is not pointer #1230

merged 2 commits into from
Jan 16, 2025

Conversation

eagleoflqj
Copy link
Member

After upgrading emscripten to 4.0.0, fcitx5 failed to compile:

FAILED: fcitx5/src/lib/fcitx-utils/CMakeFiles/Fcitx5Utils.dir/semver.cpp.o 
/home/runner/work/fcitx5-js/fcitx5-js/emsdk/upstream/emscripten/em++ -DFCITX_GETTEXT_DOMAIN=\"fcitx5\" -DFMT_HEADER_ONLY=1 -DFcitx5Utils_EXPORTS -I/home/runner/work/fcitx5-js/fcitx5-js/build/fcitx5 -I/home/runner/work/fcitx5-js/fcitx5-js/fcitx5/src/lib/fcitx-utils/.. -I/home/runner/work/fcitx5-js/fcitx5-js/build/fcitx5/src/lib/fcitx-utils/.. -isystem /home/runner/work/fcitx5-js/fcitx5-js/build/sysroot/usr/include -Wall -Wextra  -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -fexceptions -MD -MT fcitx5/src/lib/fcitx-utils/CMakeFiles/Fcitx5Utils.dir/semver.cpp.o -MF fcitx5/src/lib/fcitx-utils/CMakeFiles/Fcitx5Utils.dir/semver.cpp.o.d -o fcitx5/src/lib/fcitx-utils/CMakeFiles/Fcitx5Utils.dir/semver.cpp.o -c /home/runner/work/fcitx5-js/fcitx5-js/fcitx5/src/lib/fcitx-utils/semver.cpp
/home/runner/work/fcitx5-js/fcitx5-js/fcitx5/src/lib/fcitx-utils/semver.cpp:36:17: error: variable 'endOfNum' with type 'const auto *' has incompatible initializer of type 'std::__wrap_iter<const char *>'
   36 |     const auto *endOfNum =
      |                 ^
   37 |         std::find_if_not(str.begin(), str.end(), charutils::isdigit);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

@wengxt wengxt merged commit e787b85 into fcitx:master Jan 16, 2025
4 checks passed
@eagleoflqj eagleoflqj deleted the iter branch January 16, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants