Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return 550 when file path is a dir in handleSIZE #501

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

allape
Copy link

@allape allape commented Dec 20, 2024

@drakkan
Copy link
Collaborator

drakkan commented Dec 20, 2024

Thanks for this contribution. It is ok for me. If you can, please add a simple test case, for example within the existing test for the SIZE command.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.55%. Comparing base (9c2ba6e) to head (5e126b6).

Files with missing lines Patch % Lines
handle_files.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   86.66%   86.55%   -0.11%     
==========================================
  Files          11       11              
  Lines        2324     2328       +4     
==========================================
+ Hits         2014     2015       +1     
- Misses        236      237       +1     
- Partials       74       76       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allape
Copy link
Author

allape commented Dec 21, 2024

Sure! And I add the test case for file in folder, which makes func ftpUpload broken in file transfer_test.go, and I add the secondary condition to make it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants