BREAKING CHANGE: Add support for Opensearch and Opensearch Serverless…

… destinations (#8)
fdmsantos · Feb 19, 2024 · 7aa8e71 · 7aa8e71
1 parent 230e5e9
commit 7aa8e71
Show file tree

Hide file tree

Showing 29 changed files with 1,152 additions and 494 deletions.
diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
@@ -80,4 +80,4 @@ jobs:
           terraform-version: ${{ steps.minMax.outputs.maxVersion }}
           tflint-version: ${{ env.TFLINT_VERSION }}
           terraform-docs-version: ${{ env.TERRAFORM_DOCS_VERSION }}
-          install-hcledit: true
+          install-hcledit: true
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -56,13 +56,11 @@ All notable changes to this project will be documented in this file.
 
 ### ⚠ BREAKING CHANGES
 
-* Bump Terraform AWS Provider version to 5.0
 * Bump Terraform AWS Provider version to 5.0
 
 ### Features
 
 * Bump Terraform AWS Provider version to 5.0 ([29601cf](https://github.com/fdmsantos/terraform-aws-kinesis-firehose/commit/29601cf8ad93a9a56ac3fba37f9e8b0c968c5c3f))
-* Bump Terraform AWS Provider version to 5.0 ([4be517c](https://github.com/fdmsantos/terraform-aws-kinesis-firehose/commit/4be517c9f13b62816cc3d0ccede495ab3715d009))
 
 ### [1.9.1](https://github.com/fdmsantos/terraform-aws-kinesis-firehose/compare/v1.9.0...v1.9.1) (2023-09-16)
 

diff --git a/README.md b/README.md
diff --git a/UPGRADE-3.0.md b/UPGRADE-3.0.md
@@ -0,0 +1,36 @@
+# Upgrade from v2.x to v3.x
+
+If you have any questions regarding this upgrade process, please consult the `examples` directory
+
+If you find a bug, please open an issue with supporting configuration to reproduce.
+
+## List of backwards incompatible changes
+
+### New features
+
+1. New Destination: Opensearch
+2. New Destination: Opensearch Serverless
+
+### Variable and output changes
+
+1. Renamed variables:
+
+    - `elasticsearch_enable_vpc` -> `enable_vpc`
+    - `elasticsearch_vpc_use_existing_role` -> `vpc_use_existing_role`
+    - `elasticsearch_vpc_role_arn` -> `vpc_role_arn`
+    - `elasticsearch_vpc_subnet_ids` -> `vpc_subnet_ids`
+    - `elasticsearch_cross_account` -> `destination_cross_account`
+    - `elasticsearch_vpc_create_service_linked_role` -> `opensearch_vpc_create_service_linked_role`
+    - `elasticsearch_vpc_security_group_same_as_destination` -> `vpc_security_group_same_as_destination`
+
+2. Renamed Outputs:
+
+   - `opensearch_cross_account_service_policy` -> `elasticsearch_cross_account_service_policy`
+
+3. Default Values Changed:
+
+    - `elasticsearch_retry_duration` -> Default value changed from 3600 to 300. If used the default value, please configure this variable equals to 3600
+
+4. Added variables:
+
+   - All variables prefixed with opensearch and opensearchserverless
diff --git a/examples/elasticsearch/opensearch-in-vpc/main.tf b/examples/elasticsearch/opensearch-in-vpc/main.tf
diff --git a/examples/elasticsearch/opensearch-in-vpc/outputs.tf b/examples/elasticsearch/opensearch-in-vpc/outputs.tf
diff --git a/examples/elasticsearch/public-opensearch/main.tf b/examples/elasticsearch/public-opensearch/main.tf
diff --git a/examples/elasticsearch/public-opensearch/variables.tf b/examples/elasticsearch/public-opensearch/variables.tf
diff --git a/...elasticsearch/public-opensearch/README.md → ...search/direct-put-to-opensearch/README.md b/...elasticsearch/public-opensearch/README.md → ...search/direct-put-to-opensearch/README.md
@@ -14,10 +14,6 @@ $ terraform plan
 $ terraform apply
 ```
 
-Before sending test demo data, it's necessary execute the steps related in the following [link](https://aws.amazon.com/premiumsupport/knowledge-center/opensearch-troubleshoot-cloudwatch-logs/) in the section:
-
-`I'm unable to stream my CloudWatch log group to an OpenSearch Service domain when fine-grained access control is enabled`
-
 Note that this example may create resources which cost money. Run `terraform destroy` when you don't need these resources.
 
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
@@ -56,9 +52,7 @@ Note that this example may create resources which cost money. Run `terraform des
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| <a name="input_es_password"></a> [es\_password](#input\_es\_password) | ES Password | `string` | `null` | no |
-| <a name="input_es_username"></a> [es\_username](#input\_es\_username) | ES Username | `string` | `null` | no |
-| <a name="input_name_prefix"></a> [name\_prefix](#input\_name\_prefix) | Name prefix to use in resources | `string` | `"firehose-to-public-es"` | no |
+| <a name="input_name_prefix"></a> [name\_prefix](#input\_name\_prefix) | Name prefix to use in resources | `string` | `"firehose-to-public-opensearch"` | no |
 
 ## Outputs