Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require enable_dynamic_partitioning for dynamic_partition_append_delimiter_to_record #13

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Do not require enable_dynamic_partitioning for dynamic_partition_append_delimiter_to_record #13

merged 2 commits into from
Mar 5, 2024

Conversation

Tonkonozhenko
Copy link
Contributor

@Tonkonozhenko Tonkonozhenko commented Mar 5, 2024 •
edited
Loading

No description provided.

@fdmsantos fdmsantos self-assigned this Mar 5, 2024
@fdmsantos fdmsantos added question Further information is requested wip Working in Progress and removed question Further information is requested labels Mar 5, 2024
@fdmsantos
Copy link
Owner

Thanks for this PR.
It seems now is possible adding new line delimiter without dynamic partitioning. I think that wasn't possible.

@fdmsantos
Copy link
Owner

I have deprecated dynamic_partition_append_delimiter_to_record because i think is not makes sense anymore having the prefix "dynamic_partition". The new variable is append_delimiter_to_record .

The Old variable will be removed on next Major Version (4.0.0).

This PR will be released on version 3.3.0.

@fdmsantos fdmsantos merged commit 7e47d48 into fdmsantos:main Mar 5, 2024
2 of 24 checks passed
@fdmsantos
Copy link
Owner

Thanks @Tonkonozhenko

fdmsantos pushed a commit that referenced this pull request Mar 5, 2024
@semantic-release-bot
chore(release): version 3.3.0 [skip ci]
6675c95 
## [3.3.0](v3.2.0...v3.3.0) (2024-03-05)

### Features

* Merge pull request [#13](#13) from Tonkonozhenko/patch-1 ([7e47d48](7e47d48))
@fdmsantos
Copy link
Owner

This PR is included in version 3.3.0 🎉

@Tonkonozhenko
Copy link
Contributor Author

thank you @fdmsantos !

@Tonkonozhenko Tonkonozhenko deleted the patch-1 branch March 6, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fdmsantos fdmsantos

Labels
wip Working in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tonkonozhenko @fdmsantos