Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test local package building #518

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

7flying
Copy link
Contributor

@7flying 7flying commented Jun 22, 2023

Adds a new CI test section to check that the local package building target (make rpm) works every time.

This will help testing upcoming PR to tackle #516

@7flying 7flying force-pushed the ci-rpm-build branch 6 times, most recently from 97f1229 to 17eadd6 Compare June 22, 2023 13:18
@7flying
Copy link
Contributor Author

7flying commented Jun 22, 2023

Currently this new CI test fails (as it should) and reproduces the behaviour of #516

Copy link
Contributor

@puiterwijk puiterwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general suggestion, otherwise LGTM.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@7flying 7flying force-pushed the ci-rpm-build branch 2 times, most recently from bb357e9 to 8774ad9 Compare June 28, 2023 06:49
@7flying 7flying force-pushed the ci-rpm-build branch 2 times, most recently from 8651b30 to f853d52 Compare July 5, 2023 12:52
@7flying 7flying force-pushed the ci-rpm-build branch 2 times, most recently from 01cef09 to 8eaa633 Compare July 27, 2023 07:13
Adds a new CI test section to check that the local package building
target (`make rpm`) works every time, and that the RPMs can be installed.

Signed-off-by: Irene Diez <[email protected]>
7flying added 2 commits August 1, 2023 17:27
Signed-off-by: Irene Diez <[email protected]>
We are setting a .tar.xz extension so we should build a .tar.xz
instead of a bzip2. This sets the appropiate option for that in
make-vendored-tarfile.sh

Signed-off-by: Irene Diez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants