feat(manufacturing-server): implement an export OVs endpoint #673
+352
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
mfcg-export-ovs
branch
from
4e867cc
to
94e826f
Compare
runcom
force-pushed
the
mfcg-export-ovs
branch
from
94e826f
to
e048ac8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -117,6 +117,7 @@ | |||
| } | |||
|
|
|||
| async fn report_to_rendezvous(udt: OwnerServiceUDT) -> Result<()> { | |||
| // TODO: this below (query_data vs query_ovs_db) should be abstracted into the store's Filter's query stuff | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -234,6 +250,9 @@ | |||
| } | |||
| } | |||
|
|
|||
| // TODO: this whole implementation uses OwnershipVoucher but the store interface | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
runcom
force-pushed
the
mfcg-export-ovs
branch
from
e048ac8
to
db05bf0
Compare
Just serving an archive with all the OVs the manufacturer knows about. It'd be handy to just give this away to whoever needs these credentials and/or create a nice UI where you click a button to have them all. The post-MVP, with a UI, would be to just have a UI that is able to list all the device credentials, let you select which one you want, download them in an archive, profit. Not there yet. Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
mfcg-export-ovs
branch
from
db05bf0
to
6b962d4
Compare
say-paul
reviewed
Sep 19, 2024
| @@ -461,6 +497,24 @@ where | |||
| V: Serializable + Send + Sync + Clone + 'static, | |||
| MKT: crate::MetadataLocalKey + 'static, | |||
| { | |||
| async fn load_all_data(&self) -> Result<Vec<V>, StoreError> { | |||
There was a problem hiding this comment.
Why not referring a single function for all load_all_data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just serving an archive with all the OVs the manufacturer knows about.
It'd be handy to just give this away to whoever needs these credentials
and/or create a nice UI where you click a button to have them all.
The post-MVP, with a UI, would be to just have a UI that is able to list
all the device credentials, let you select which one you want, download
them in an archive, profit. Not there yet.
This is based on #671 - so let's merge that first
Signed-off-by: Antonio Murdaca [email protected]