-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manufacturing-server): implement an export OVs endpoint #673
base: main
Are you sure you want to change the base?
Conversation
4e867cc
to
94e826f
Compare
94e826f
to
e048ac8
Compare
@@ -117,6 +117,7 @@ | |||
} | |||
|
|||
async fn report_to_rendezvous(udt: OwnerServiceUDT) -> Result<()> { | |||
// TODO: this below (query_data vs query_ovs_db) should be abstracted into the store's Filter's query stuff |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
@@ -234,6 +250,9 @@ | |||
} | |||
} | |||
|
|||
// TODO: this whole implementation uses OwnershipVoucher but the store interface |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
e048ac8
to
db05bf0
Compare
Just serving an archive with all the OVs the manufacturer knows about. It'd be handy to just give this away to whoever needs these credentials and/or create a nice UI where you click a button to have them all. The post-MVP, with a UI, would be to just have a UI that is able to list all the device credentials, let you select which one you want, download them in an archive, profit. Not there yet. Signed-off-by: Antonio Murdaca <[email protected]>
db05bf0
to
6b962d4
Compare
@@ -461,6 +497,24 @@ where | |||
V: Serializable + Send + Sync + Clone + 'static, | |||
MKT: crate::MetadataLocalKey + 'static, | |||
{ | |||
async fn load_all_data(&self) -> Result<Vec<V>, StoreError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not referring a single function for all load_all_data?
Just serving an archive with all the OVs the manufacturer knows about.
It'd be handy to just give this away to whoever needs these credentials
and/or create a nice UI where you click a button to have them all.
The post-MVP, with a UI, would be to just have a UI that is able to list
all the device credentials, let you select which one you want, download
them in an archive, profit. Not there yet.
This is based on #671 - so let's merge that first
Signed-off-by: Antonio Murdaca [email protected]