Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying a bit weighting of completion list SmartMatch #1173

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

elsassph
Copy link
Member

@elsassph elsassph commented Apr 9, 2016

Fixes issue #1161

Note: collateral damage is that abbreviation matching is now only enabled for all-uppercase words.

…artMatch.

Collateral damage is that abbreviation matching is now only enabled for all-uppercase words.
@Meychi
Copy link
Member

Meychi commented Jun 17, 2016

@Neverbirth, @SlavaRa, @wise0704, comments?

@Neverbirth
Copy link
Contributor

I think I completely missed this PR until now... not a part of code I really know. I'd need to try out how the completion feel with the abbreviation change, by looking at the changes it seems to me the issue is already fixed without that behaviour change?

@wise0704
Copy link
Contributor

wise0704 commented Jun 19, 2016

image
Since the method is public, I think you need to add a method with the old signature too...

Something like:

public static int SmartMatch(string label, string word, int len)
{
    return SmartMatch(label, word, len, word == word.ToUpperInvariant());
}

@elsassph
Copy link
Member Author

It needs unit tests as well, because the weighting was changed a bit randomly.

@Meychi
Copy link
Member

Meychi commented Jun 20, 2016

@elsassph: Will you add tests here or should we merge as such?

@elsassph
Copy link
Member Author

We shouldn't merge without tests I believe. I'll try to do it quickly.

@Meychi
Copy link
Member

Meychi commented Aug 24, 2016

@elsassph, any progress? :)

@elsassph
Copy link
Member Author

Well... I haven't been able to run tests at all so far :/

@Meychi
Copy link
Member

Meychi commented Oct 21, 2016

Any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants