WIP Add GCS registry support to feast-serving #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Klegar <[email protected]>
|
There are some changes to |
jklegar
commented
Jun 2, 2021
| registry = Registry.parseFrom(inputStream); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Unable to retrieve registry", e); | ||
| } |
There was a problem hiding this comment.
should move this out into a separate method since it's shared
Signed-off-by: Jacob Klegar <[email protected]>
jklegar
commented
Jun 2, 2021
| registry = Registry.parseFrom(inputStream); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Unable to retrieve registry", e); | ||
| } |
jklegar
commented
Jun 2, 2021
| .build()); | ||
| BlobInfo blobInfo = BlobInfo.newBuilder(BlobId.of(bucketName, objectName)).build(); | ||
| Blob blob = storage.create(blobInfo, registryProto.toByteArray()); | ||
| registryClient = TestUtils.getApiClientForRegistry(bucketName, objectName); |
There was a problem hiding this comment.
this code is shared in all the serving/it/ files
|
There's likely also additional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacob Klegar [email protected]