-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal Support #63
Open
du5rte
wants to merge
13
commits into
feathericons:master
Choose a base branch
from
du5rte:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary process until the original package accepts the PR and pushes to npm
This is working perfectly on react-native. Can someone review and merge? Thank you btw, saved my day. |
Update package.json module to be able to read from source files rather than compile
How's the state of this getting merged? |
Just stumbled across this, sounds promising - any update on the merge conflict in |
time goes fast - do it 🗡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added svgs to support both
react
andreact-native
.fixes:
Stays the same for users
Nothing changes in how users use the library. Behind the scenes
svgs
detects if the environment is run for web or native.How
svgs
worksOn web, most components are just renamed to conform with
react-native-svg
exports, here:on native, it exports
react-native-svg
, here: