[Hdfs Utils] add uri param to filesystem get api #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @xiaoyongzhu |
|
@windoze could you help with tagging the right reviewers ? |
|
@jaymo001 @rakeshkashyap123 could you please review ? cc @windoze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when HDFS is configured with fs.defaultsFS pointing to blob storage, we are not able to give local path as source location in feature definition config. this is because hdfsutils.scala uses FileSystem.get(conf) API. instead using FileSystem.get(URI, conf) solves the problem where one can give source location as file:///xyz even though defaultFS points to blob.
Testing
manually tested using notebook session configured with fs.defaultFS= wasbs://xyz
FileSystem.get(conf).exists("file:///path") returns false
FileSystem.get(URI, conf).exists("file:///path") returns true
Does this PR introduce any user-facing changes?