Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5680 Sass linter #5699

Closed
wants to merge 23 commits into from
Closed

5680 Sass linter #5699

wants to merge 23 commits into from

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Apr 17, 2023

Summary

Adding Stylelint to our build process

Required reviewers

A few who can check through rules and various types of pages and their appearance.

Impacted areas of the application

Technically the entire site. Realistically, very little will be affected but I'd like to check:

  • accordions
  • callouts
  • cards
  • data-landing-callouts
  • components/documents (box-shadow)
  • components/examples (box-shadow)
  • components/form-styles (hover.is-disabled, [disabled])
  • mega-menu (.mega box-shadow)
  • mixins/u-visually-hidden
  • pres-finance-map (currency column font, flex, stroke)
  • org chart

Screenshots

Should be no visible changes

Related PRs

none

How to test

  • Pull the branch
  • npm i
  • npm run build (or just npm run build-sass) (should be no errors, though there may be deprecation stylelint warnings)
  • If your IDE support it (VS Code should)
    • Open a scss file and make some errors
    • Those errors should be indicated
  • Auto fixing formatting errors
    • Open a scss file and make some errors that can be easily fixed (like extra spaces at the end of a line)
    • Save the file
    • npm run format-sass-fix
    • Check that the errors have been fixed
  • Pages
    • Make sure the components above are 'normal' across widths (will add links or better descriptions)

@rfultz rfultz self-assigned this Apr 17, 2023
@rfultz rfultz changed the title Feature/5680 sass linter 5680 Sass linter Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #5699 (cad753b) into develop (1d03f9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5699   +/-   ##
========================================
  Coverage    78.16%   78.16%           
========================================
  Files          282      282           
  Lines         9285     9285           
  Branches       650      650           
========================================
  Hits          7258     7258           
  Misses        2027     2027           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rfultz
Copy link
Contributor Author

rfultz commented Aug 4, 2024

Closing in favor of the PR for #6387

@rfultz rfultz closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Sass Upgrade - Stylelint
1 participant