Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6561 AO Search Pagination and Page Offset #6590

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Dec 11, 2024

Summary

Fixing the pagination buttons for AOs and resetting the offset when filters change.

Required reviewers

  • 1 Front-end and/or UX?

Impacted areas of the application

The AO search template, its pagination and its filters controls (all of them independent from the other legal search tools from datatables and those filters)

Screenshots

image

Related PRs

None

How to test

  • Pull the branch
  • npm run build
  • manage.py runserver
  • Pagination - first & current page buttons (sample url)
    • Should start on page 1
    • Should show the page 1 button (as opposed to being absent)
    • Should not offer a page 3
    • Clicking page 2 should go to page 2
  • Pagination - end (sample url)
    • Shouldn't offer more pages than exist
  • Resetting to offset 0 (sample url)
    • Should start on page 2
    • Clicking the x to remove the 'testing' tag at the top
    • Results should refresh and the
    • pagination should revert to page 1

@rfultz rfultz added this to the 27.1 milestone Dec 11, 2024
@rfultz rfultz self-assigned this Dec 11, 2024
@rfultz rfultz modified the milestones: 27.1, 27.2 Dec 23, 2024
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.72%. Comparing base (8f7972f) to head (2e9f7e6).
Report is 14 commits behind head on release/public-20250114.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/public-20250114    #6590   +/-   ##
========================================================
  Coverage                    79.72%   79.72%           
========================================================
  Files                          235      235           
  Lines                         5159     5159           
========================================================
  Hits                          4113     4113           
  Misses                        1046     1046           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfultz rfultz modified the milestones: 27.2, 27.3 Jan 7, 2025
@patphongs patphongs changed the base branch from develop to release/public-20250114 January 10, 2025 17:01
Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @rfultz

@patphongs patphongs merged commit 1c9154d into release/public-20250114 Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

AO pagination bug
2 participants