Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade psycopg #6662

Merged
merged 1 commit into from
Feb 4, 2025
Merged

upgrade psycopg #6662

merged 1 commit into from
Feb 4, 2025

Conversation

cnlucas
Copy link
Member

@cnlucas cnlucas commented Jan 30, 2025

Summary (required)

This PR upgrades our db driver to make it compatible with gevent

changes---https://www.psycopg.org/psycopg3/docs/basic/from_pg2.html

NOTE I'm not upgrading to the latest versions due to open issues in the gevent repos with performance.

Required reviewers

1-2 devs

Impacted areas of the application

General components of the application that this PR will affect:

  • connections to db waiting should be once again non-blocking

How to test

  • gh pr checkout 6662
  • pyenv virtualenv 3.11.9 cms
  • pyenv activate cms
  • pip install -r requirements.txt
  • pip install -r requirements-dev.txt
  • npm i && npm run build
  • cd fec
  • python manage.py runserver
  • pytest

Load tests here

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (44c26c2) to head (0b6ed98).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6662   +/-   ##
========================================
  Coverage    79.67%   79.67%           
========================================
  Files          236      236           
  Lines         5172     5172           
========================================
  Hits          4121     4121           
  Misses        1051     1051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnlucas cnlucas force-pushed the feature/upgrade-psycopg branch from 544e6a8 to 0b6ed98 Compare February 4, 2025 17:31
Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cnlucas for thoroughly testing the psycopg minor upgrade and for highlighting the potential issues we might face with the latest version. I also really appreciate you documenting all the details!

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me. Thanks

@fec-jli fec-jli merged commit 1998fff into develop Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Upgrade psycopg
3 participants