Very Rough Draft of App Factory #6123
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnlucas
force-pushed
the
feature/switch-to-app-factory
branch
from
54ece28 to
505ea4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES:
I'm keeping instances of importing the celery app, bc if we don't need to switch to a factory for that I'd like to keep it as is for now
flask_restful setup is now in api_setup.py (it's too closely linked to the v1 blueprint to seperate out all extensions)
Things that are working:
starting the flask server, running queries
starting gunicorn server, running queries
creating a test db and refreshing mat views
cli commands for legal, posting to slack
Things that are obviously not working:
ALL pytest
Unclear:
Celery
Downloads
CORS and NPlusOne extensions *may need to switch to init app? will test later)