Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change before and after filters #6128

Open
wants to merge 1 commit into
base: release/public-20250211
Choose a base branch
from

Conversation

tmpayton
Copy link
Contributor

@tmpayton tmpayton commented Feb 6, 2025

Summary (required)

This PR changes the meaning of the proximity_filter to mean that the proximity_filter_term comes before or after the q_proximity terms.

Required reviewers 1 - 2 developers

Impacted areas of the application

General components of the application that this PR will affect:

  • legal search

How to test

  • checkout this branch
  • start elasticsearch ./elasticsearch
  • pytest
  • create case index: python cli.py create_index case_index
  • load sample data for mur ) : python cli.py load_current_murs
  • see test URLs below

Test URLs reference the following documents: MUR 8285

http://127.0.0.1:5000/v1/legal/search/?q_proximity=Dowell%20daunting&max_gaps=2&proximity_filter=after&proximity_filter_term=remediation

http://127.0.0.1:5000/v1/legal/search/?q_proximity=Dowell%20daunting&max_gaps=2&proximity_filter=before&proximity_filter_term=remediation

@tmpayton tmpayton requested a review from cnlucas February 6, 2025 16:09
@tmpayton tmpayton changed the base branch from develop to release/public-20250211 February 6, 2025 16:09
@tmpayton tmpayton requested review from pkfec and fec-jli February 6, 2025 16:10
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (6d7e30d) to head (06182ec).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           release/public-20250211    #6128      +/-   ##
===========================================================
- Coverage                    88.53%   88.51%   -0.03%     
===========================================================
  Files                           82       82              
  Lines                         9191     9191              
===========================================================
- Hits                          8137     8135       -2     
- Misses                        1054     1056       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Change the proximity filter term order
1 participant