Skip to content

Commit

Permalink
Updated Github action (#125)
Browse files Browse the repository at this point in the history
* added cache step to github action, updated task versions

* string-safe workflow name

* bad id name in npm cache

* use core node setup

* removed cache flag

* updated coalesced values for node 18 - it's too fast
  • Loading branch information
fed135 authored Oct 24, 2022
1 parent eedde87 commit 6c50c0b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/pr-validation.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pr-validation
name: "pr-validation"

on:
pull_request:
Expand All @@ -12,17 +12,17 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [14.x, 16.x, 18.x]

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Start Redis
uses: supercharge/[email protected]
- name: npm install, build, and test
- name: npm install, build, test and benchmark
run: |
npm install
npm run lint
Expand Down
2 changes: 1 addition & 1 deletion tests/profiling/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
},
assert: {
completed: [300000, 300000],
coalescedHit: [8000, 50000],
coalescedHit: [7000, 50000],
cacheHits: [35000, 50000],
timeouts: [0, 0],
batches: [4800, 5300],
Expand Down

0 comments on commit 6c50c0b

Please sign in to comment.