[WIP] Refactor comparison #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create BuildSource object which might point to Koji tag or Brew tag * Create Comparison object, which stores data about comparison results * Render html, json and txt output via templates engine * Allow full comparison or comparison per package
bookwar
force-pushed
the
refactoring
branch
from
38e422e to
e1047cf
Compare
jimbair
reviewed
Sep 28, 2020
jimbair
reviewed
Sep 28, 2020
|
Overall, it looks good to me; just a few suggestions listed above. :) |
sturivny
reviewed
Sep 28, 2020
| if source_id == "rhel": | ||
| # FIXME | ||
| infra = koji.ClientSession('https://brew') | ||
| tag = "rhel-9.0.0-alpha" |
There was a problem hiding this comment.
I'd also added a condition here where source_id doesn't equal all these cases.
It will help to debug if something goes wrong.
sturivny
reviewed
Sep 28, 2020
| """ | ||
| merged_packages = set() | ||
|
|
||
| distro_url = "https://tiny.distro.builders" |
There was a problem hiding this comment.
All those constant should be in a separate place.
| else: | ||
| content = sorted(get_content()) | ||
|
|
||
| C = Comparison(content, source1, source2) |
There was a problem hiding this comment.
Not the best name for the instance :)
| between different distributions. | ||
| """ | ||
|
|
||
| epoch = "0" |
There was a problem hiding this comment.
Is it necessary to create a separate variable here?
Couldn't find where it uses instead of return .
|
|
||
| logging.debug("downloading {url}".format(url=url)) | ||
|
|
||
| r = requests.get(url, allow_redirects=True) |
There was a problem hiding this comment.
Please, use try construction for requests.
| "source2": "{{ source2 }}", | ||
| "stats": {{ stats|tojson }}, | ||
| "packages": {{ results|tojson }} | ||
| } |
There was a problem hiding this comment.
Add a newline at the end of this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of the eln-check script