Fix our dist-git CI #2686
Merged
Fix our dist-git CI #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
reviewed
May 15, 2023
| # pyrpkg to implement, we can refresh the Commands class after every | ||
| # import - even if it is not elegant | ||
| # note: if https://pagure.io/rpkg/issue/690 is resolved, you may delete this | ||
| commands = _load_command(opts, reponame, repo_dir) |
There was a problem hiding this comment.
@onosek do you think this change makes sense?
There was a problem hiding this comment.
Ping @onosek :-) seems like we could rather fix the library. Can you give us guidance?
There was a problem hiding this comment.
I prepared a fix that potentially solves the issue:
https://bodhi.fedoraproject.org/updates/?search=rpkg-1.66-8
praiskup
reviewed
May 15, 2023
|
Should we have a particular versioned |
in case of importing, the content of directory in `reponame` changes. To update the state of `Commands` class isn't an easy process - look how much logic pyrpkg.cli.cliClient.load_cmd has and the logic is written for context in cliClient, not for Commands which we are using. Considering this wouldn't be an easy task for pyrpkg to implement, we can refresh the Commands class after every import - even if it is not elegant
Related: fedora-copr#2317 pyrpkg don't allow using pre-generated SRPM by default. They created for this `allow_pre_generated_srpm` for us in 1.66-6 version of rpkg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is an attempt to shut down our CI problems with pyrpkg
dist-git: refresh pyrpkg.Commands after import_srpmcommit - WDYT? this shouldn't be a problem for us from the efficiency sideafter merging this, don't forget to merge https://pagure.io/fedora-infra/ansible/pull-request/1386
Fixes #2608
Fixes #2317