Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: support building in openEuler #2784

Merged
merged 1 commit into from
Jun 27, 2023
Merged

frontend: support building in openEuler #2784

merged 1 commit into from
Jun 27, 2023

Conversation

pkking
Copy link
Contributor

@pkking pkking commented Jun 21, 2023 •
edited
Loading

Some of the python packages have different name in openEuler, so i switch to python3dist(xxx)

@praiskup
Copy link
Member

I'd vote for switching all the dependencies to the same format, not just some of those. Team, WDYT?
Also, can you please keep the deps on the same line and just change the format? Just to simplify the review (so we are sure nothing is lost, or added).

@pkking pkking requested a review from praiskup June 21, 2023 07:13
@Conan-Kudo
Copy link
Contributor

You should be using python3dist() format for everything anyway. There's no reason not to...

@pkking pkking force-pushed the frontend branch 2 times, most recently from f0d3d2e to 11129e7 Compare June 26, 2023 08:46
@pkking pkking requested a review from praiskup June 26, 2023 11:08
@praiskup
Copy link
Member

We don't have the installability test :-( but I see this issue now:

  - nothing provides python3dist(mod_wsgi) needed by copr-frontend-1.200-1.git.37.11129e7.fc38.noarch from copr:copr.fedorainfracloud.org:group_copr:copr-pull-requests:pr:2784
  - nothing provides python3dist(zmq) needed by copr-frontend-1.200-1.git.37.11129e7.fc38.noarch from copr:copr.fedorainfracloud.org:group_copr:copr-pull-requests:pr:2784

@praiskup
Copy link
Member

This looks good to me, can anyone else have yet another look?

@praiskup praiskup merged commit 02aa009 into fedora-copr:main Jun 27, 2023
7 checks passed
@pkking pkking mentioned this pull request Jul 26, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrostyX FrostyX FrostyX approved these changes

@praiskup praiskup Awaiting requested review from praiskup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkking @praiskup @Conan-Kudo @FrostyX