fix: python build failed in openeuler #2796
Conversation
| @@ -147,6 +147,7 @@ BuildRequires: python3-pytest | |||
| BuildRequires: python3-requests-gssapi | |||
| BuildRequires: python3-future | |||
| BuildRequires: python3-filelock | |||
| BuildRequires: pyproject-rpm-macros | |||
There was a problem hiding this comment.
This seems redundant. Per guidelines, we need python3-devel:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
There was a problem hiding this comment.
Hmm, I am not sure why we actually need all the other requirements that should be automatically generated.
There was a problem hiding this comment.
This seems redundant. Per guidelines, we need python3-devel: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
In openEuler we do not preset pyproject-rpm-macros as python3-devel's deps, so we need it directly, maybe specified only in openEuler?
There was a problem hiding this comment.
ACK. I think we can keep it (seems like a distro glitch).
pkking
force-pushed
the
python-in-openeuler
branch
from
d26c50c
to
4be9df3
Compare
python/python-copr.spec
Outdated
| @@ -1,6 +1,6 @@ | |||
| %global srcname copr | |||
|
|
|||
| %if 0%{?fedora} || 0%{?rhel} > 7 | |||
| %if 0%{?fedora} || 0%{?rhel} > 7 || 0%{?openEuler} | |||
There was a problem hiding this comment.
Would you mind using !0%{?rhel} || 0%{?rhel} > 7 ? Any new distro will directly use python3.
There was a problem hiding this comment.
Would you mind using
!0%{?rhel} || 0%{?rhel} > 7? Any new distro will directly use python3.
Done
Signed-off-by: Li Chaoran <[email protected]>
pkking
force-pushed
the
python-in-openeuler
branch
from
4be9df3
to
5d43c94
Compare
No description provided.