Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for delete actions before forking #2804

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Wait for delete actions before forking #2804

merged 1 commit into from
Aug 9, 2023

Conversation

nikromen
Copy link
Member

Fixes #2698

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2023
View reviewed changes
common/copr_common/enums.py Fixed Show fixed Hide fixed
common/copr_common/enums.py Fixed Show fixed Hide fixed
@nikromen nikromen force-pushed the action-delete-race-condition branch from eec74e6 to ef8d8c3 Compare July 12, 2023 14:00
@nikromen
Copy link
Member Author

/packit build

1 similar comment
@nikromen
Copy link
Member Author

/packit build

@nikromen nikromen force-pushed the action-delete-race-condition branch 2 times, most recently from e3eb0c9 to eb718e6 Compare July 18, 2023 11:39
@nikromen
Copy link
Member Author

/packit build

@nikromen nikromen mentioned this pull request Jul 18, 2023
Merged
@praiskup praiskup self-assigned this Jul 24, 2023
@nikromen nikromen force-pushed the action-delete-race-condition branch from eb718e6 to f192df7 Compare August 2, 2023 14:16
@nikromen nikromen force-pushed the action-delete-race-condition branch from f192df7 to f548fdc Compare August 2, 2023 14:21
@nikromen nikromen requested a review from praiskup August 2, 2023 14:23
@nikromen nikromen force-pushed the action-delete-race-condition branch from f548fdc to e800943 Compare August 3, 2023 15:56
@nikromen
Copy link
Member Author

nikromen commented Aug 3, 2023

/packit build

@praiskup
Copy link
Member

praiskup commented Aug 4, 2023

Instead of rebuilding everything in packit, I think it is easier to manually build the common package into the @copr/copr-dev temporarily. Then you can just retrigger the failed (non-Packit) CI builds.

@nikromen nikromen force-pushed the action-delete-race-condition branch from e800943 to e5115c2 Compare August 7, 2023 12:03
@nikromen nikromen force-pushed the action-delete-race-condition branch 4 times, most recently from 2161d1b to b46ed9a Compare August 7, 2023 13:02
@praiskup
Copy link
Member

praiskup commented Aug 7, 2023

Hm, would you mind adding a small test with "delete" and "create" actions, checking if "create" is not propagated to the pending-jobs output? Seems like there already is f_actions fixture.

@nikromen nikromen force-pushed the action-delete-race-condition branch from b46ed9a to d644471 Compare August 7, 2023 17:11
@nikromen nikromen force-pushed the action-delete-race-condition branch 2 times, most recently from 81de0a1 to 889ed5e Compare August 7, 2023 17:23
praiskup
praiskup reviewed Aug 8, 2023
View reviewed changes
frontend/coprs_frontend/tests/test_views/test_backend_ns/test_backend_general.py
@@ -11,6 +11,7 @@
from coprs import app


# pylint: disable=unused-argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefix the unused arguments with _ typically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those arguments are fixtures so _ prefix wont help here

praiskup added a commit to praiskup/copr that referenced this pull request Aug 8, 2023
@praiskup
Fix for fedora-copr#2804 review
db6c730
@nikromen
frontend: don't show new action task if namespace is deleting itself
e5ab9b3 
wait for the end of the deletion of project to avoid race
condition when other action like fork or create is called
immidiatelly after delete
@nikromen nikromen force-pushed the action-delete-race-condition branch from 889ed5e to e5ab9b3 Compare August 8, 2023 09:43
praiskup
praiskup approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praiskup praiskup merged commit 857f946 into fedora-copr:main Aug 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praiskup praiskup praiskup approved these changes

Assignees

@praiskup praiskup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

llvm-snapshots copr is missing gpg key
2 participants
@nikromen @praiskup