Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --logs argument to download-build command #2815

Closed
wants to merge 1 commit into from

Conversation

jpandia
Copy link
Contributor

@jpandia jpandia commented Jul 17, 2023

Overview:

This pull request adds a new feature to Copr allowing a user to directly download the logs of a Copr build rather than download the entire build.

Changes Made:

I added an argument called logs that supplements the already existing arguments "rpms" and "spec" to the command "copr cli download-build "

Testing:

I tested the command by running copr in a local fedora environment on copr builds that I had previously ran.

Conclusion:

Ultimately, adding this argument allows users to not have to download unnecessary files. My tech lead Josh Stone and I decided to create this command because I was creating a python script that looks for test cases that failed on certain architectures and passed on others. For this, only the logs were needed. If there are other applications that only require logs and not the entire build information, then this will be a useful push.

Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@praiskup
Copy link
Member

Even though, we should have useful commit-message. I can see you spent some time writing the initial comment here, can you please transform it into a commit message?

@jpandia jpandia changed the title Update main.py Add --logs argument to download-build command Jul 18, 2023
@praiskup
Copy link
Member

I updated the commit message manually: 7407748

@praiskup praiskup closed this Jul 19, 2023
@praiskup
Copy link
Member

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants