Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make build works in openEuler #2821

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

pkking
Copy link
Contributor

@pkking pkking commented Jul 21, 2023

No description provided.

@@ -1,4 +1,4 @@
%if 0%{?rhel} > 7 || 0%{?fedora}
%if 0%{?rhel} > 7 || 0%{?fedora} || 0%{?openEuler}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can revert the if-else again like %if 0%{?rhel} && 0%{?rhel} <= 7. Every other distro will be python3 compliant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praiskup Done

Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@praiskup praiskup merged commit 47dac08 into fedora-copr:main Jul 24, 2023
7 checks passed
@pkking pkking mentioned this pull request Jul 26, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants