frontend: allow config-based build-chroot tags #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
praiskup
force-pushed
the
praiskup-tagging-builds
branch
from
cbb4e0e
to
10aa53c
Compare
praiskup
force-pushed
the
praiskup-tagging-builds
branch
2 times, most recently
from
c2288e2
to
5ac2eec
Compare
praiskup
force-pushed
the
praiskup-tagging-builds
branch
from
5ac2eec
to
b0cf76e
Compare
FrostyX
reviewed
Aug 8, 2023
| # regexp pattern is matched against BuildChroot fully qualified names in the | ||
| # format "user/project:dirname/chroot_name/pkgname", so example rule might | ||
| # look like | ||
| # "pattern": "r"john/projectX.*/fedora-.*-x86_64/chromium", |
There was a problem hiding this comment.
nit: There shouldn't be " before r"..."
| """ | ||
| if "EXTRA_BUILDCHROOT_TAGS_COMPILED" in app.config: | ||
| return | ||
| new_array = app.config["_EXTRA_BUILDCHROOT_TAGS_COMPILED"] = [] |
There was a problem hiding this comment.
I'd drop the new_array and access _EXTRA_BUILDCHROOT_TAGS_COMPILED directly.
| """ | ||
| Given the build_id, finish the build with succeeded state | ||
| Given the build_id, finish the source build (but don't import) |
There was a problem hiding this comment.
finish_srpm_and_import but finish the source build (but don't import). I am confused 😄
That is a duplicate info to the 'down_revision' field, and we often forget to update when rebasing against other revisions.
This feature is to get "high performance" builders into Copr: https://github.com/fedora-copr/debate/blob/main/2023-07-28-high-performance-builders.md praiskup/resalloc#118
praiskup
force-pushed
the
praiskup-tagging-builds
branch
from
b0cf76e
to
adb9eb5
Compare
|
Thank you for the review, updated! |
praiskup
added a commit
to praiskup/copr
that referenced
this pull request
Aug 8, 2023
This feature is to get "high performance" builders into Copr: https://github.com/fedora-copr/debate/blob/main/2023-07-28-high-performance-builders.md praiskup/resalloc#118 Relates: fedora-copr#2834
FrostyX
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is to get "high performance" builders into Copr: https://github.com/fedora-copr/debate/blob/main/2023-07-28-high-performance-builders.md praiskup/resalloc#118