backend: don't eat the "build detail collecting" traceback #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "log.exception()" which passes the traceback down to backend.log. This helps me to debug some release-blocker issue right now, normally we (when infra is OK) we shouldn't ever catch an exception there.
nikromen
approved these changes
Aug 11, 2023
This actually causes error 500 upon "update" request from copr backend background worker, eventually leading to never-stopped builder process. Relates: fedora-copr#2841
praiskup
force-pushed
the
praiskup-dont-swallow-specfile-errors
branch
from
7a57560
to
07e68c3
Compare
FrostyX
reviewed
Aug 11, 2023
| if exclusivearch and arch not in exclusivearch: | ||
| finish(chroot, StatusEnum("skipped")) | ||
|
|
||
| if arch in upd_dict["results"]["excludearch"]: | ||
| excludearch = upd_dict["results"].get("excludearch") |
There was a problem hiding this comment.
The change is okay and will fix the traceback, so +1.
But IMHO the "exclusivearch" and "excludearch" should always be present, so there is probably a bug earlier in the pipeline. Per @praiskup on Slack, it seems that we are using RPMResults instead of SRPMResults for custom method.
There was a problem hiding this comment.
Should I drop the commit? Or what do you prefer?
FrostyX
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "log.exception()" which passes the traceback down to backend.log. This helps me to debug some release-blocker issue right now, normally we (when infra is OK) we shouldn't ever catch an exception there.