Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: dont check dirname presence in action_build #3106

Merged
merged 1 commit into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cli/copr_cli/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,14 @@ def action_build(self, args):
# Before we start uploading potentially large source RPM file, make sure
# that the user has valid credentials and can build in the project.
self.client.build_proxy.check_before_build(
username, projectname, project_dirname, buildopts)
ownername=username,
projectname=projectname,
# documentation says user can create directory with copr build, but
# /build/check-before-build endpoint checks for presence of this
# dirname even before creating it in this check.
project_dirname=None,
buildopts=buildopts,
)

builds = []
for pkg in args.pkgs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def check_before_build():
copr = get_copr()

# Raises an exception if CoprDir doesn't exist
if data["project_dirname"]:
if data.get("project_dirname"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CoprDirsLogic.get_by_copr(copr, data["project_dirname"])

# Permissions check
Expand Down
Loading