rpmbuild: no Jinja-vars in config_opts keys #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jinja statements are only expanded in the values of the config_opts dictionary, not in the keys. The new mock-core-configs version 40.2 contains a Jinja condition in the package_manager value. Therefore, we cannot simply use it as a key in config_opts. Since yum.conf and dnf.conf are aliases (starting from Mock 2.1), and dnf5.conf (starting from Mock 5.0+), we can avoid using the variable as a key entirely. Relates: rpm-software-management/mock@5d620ad326d Relates: rpm-software-management/mock#1332
FrostyX
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jinja statements are only expanded in the values of the config_opts dictionary, not in the keys. The new mock-core-configs version 40.2 contains a Jinja condition in the package_manager value. Therefore, we cannot simply use it as a key in config_opts.
Since yum.conf and dnf.conf are aliases (starting from Mock 2.1), and dnf5.conf (starting from Mock 5.0+), we can avoid using the variable as a key entirely.
Relates: rpm-software-management/mock@5d620ad326d
Relates: rpm-software-management/mock#1332
Fixes: #3146